rahil-c opened a new pull request, #14173:
URL: https://github.com/apache/hudi/pull/14173

   ### Describe the issue this Pull Request addresses
   
   Currently in hudi today we have many abstractions for doing file writing, as 
seen during the integration with lance 
https://github.com/apache/hudi/discussions/14128. The main goal is if we should 
try to consolidate these interfaces and their implementation so it is easier to 
add new file formats in the future.
   
   Here are some of the core interfaces I have encountered thus far:
   
   * HoodieFileWriter (highest level interface for writing) 
   * HoodieSparkFileWriter (impl of the above for spark side)
   * HoodieInternalRowWriter(duplicate interface that seems to be used only for 
bulk insert, potentially can be consolidated with top level interface)
   
   ### Summary and Changelog
   
   * consolidate the logic from `HoodieInternalRowWriter` and its impl 
`HoodieInternalRowParquetWriter` into the `HoodieSparkParquetWriter`
   * Mark classes as deprecated
   * Port original test logic to use `HoodieSparkFileWriter`
   
   ### Impact
   
   Low impact, marking older interfaces as deprecated
   
   ### Risk Level
   
   medium, as we want to ensure that now operations work correctly when 
removing this `HoodieInternalRowWriter` interface which has been used for bulk 
insert flow. We should ensure CI which has many bulk inserts tests is passsing.
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to