parisni opened a new pull request, #14235: URL: https://github.com/apache/hudi/pull/14235
feat: support nested doc datasource. improvement of #8683 ## Goal: Full comments support for hudi, from source to target ## Context: as of 1.x and previous, the field comment support is partial: - hive-sync and co, allow to sync the comments only on the first field level - the comments are retrieved from the schema resolver. while they are stored in the hudi avro schema, they can't yet be extracted, since it ignore the avro docs. - avro support nested comments while hive metastore and co only support first layer of comment. However spark can store the schema structure in a property, and if exists, use it in priority. - Hudi currently optionally supports writing the spark structure, but it does not store comments at all, and rely on parquet schema which don't capture the comments anyway ## What this PR covers: 1. enable extracting the nested comments out of avro schema 2. replaces the generation of the spark structure with a new util, directly leveraging avro and not parquet schema anymore 3. provides full support for spark schema comments storage 4. enable metastore first level comment (they were partially working because of the lack of support in 1. ## Reminder: - to activate the metastore comment, set: [hoodie.datasource.hive_sync.sync_comment](https://hudi.apache.org/docs/0.15.0/configurations#hoodiedatasourcehive_syncsync_comment) - to activate the spark schema structure comments, set: `[hoodie.datasource.hive_sync.sync_as_datasource](https://hudi.apache.org/docs/0.15.0/configurations#hoodiedatasourcehive_syncsync_as_datasource)` ### Describe the issue this Pull Request addresses <!-- Either describe the issue inline here with motivation behind the changes (or) link to an issue by including `Closes #<issue-number>` for context. If this PR includes changes to the storage format, public APIs, or has breaking changes, use `!` (e.g., feat!: ...) --> ### Summary and Changelog <!-- Short, plain-English summary of what users gain or what changed in behavior. Followed by a detailed log of all the changes. Highlight if any code was copied. --> ### Impact <!-- Describe any public API or user-facing feature change or any performance impact. --> ### Risk Level <!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk. If medium or high, explain what verification was done to mitigate the risks. --> ### Documentation Update <!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none". - The config description must be updated if new configs are added or the default value of the configs are changed. - Any new feature or user-facing change requires updating the Hudi website. Please follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. --> ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [ ] Enough context is provided in the sections above - [ ] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
