1fanwang opened a new pull request, #18721: URL: https://github.com/apache/hudi/pull/18721
### Describe the issue this Pull Request addresses Closes https://github.com/apache/hudi/issues/17105. JIRA: https://issues.apache.org/jira/browse/HUDI-9624. Before this change, setting `hoodie.payload.event.time.field` without enabling `hoodie.write.track.event.time.watermark` silently omitted watermark metadata from commits. The write config now warns that tracking is disabled and names the setting that enables it. ### Summary and Changelog Write-config validation checks the existing event-time field and watermark tracking settings. When the field is non-empty and tracking is false, it emits one advisory warning. Commit metadata behavior and defaults are unchanged. ### Impact Users with this configuration receive a warning when the write config is built. There is no public API, storage format, or performance change. ### Risk Level Low. The condition reads two existing write-config properties. ### Documentation Update None. This change adds no config and changes no default. ### Testing ```bash mvn -pl hudi-client/hudi-client-common -am -DskipITs \ -Dtest=TestHoodieWriteConfig#testWarnsWhenEventTimeFieldSetWithoutWatermarkTracking \ -Dsurefire.failIfNoSpecifiedTests=false test mvn -pl hudi-client/hudi-client-common -DskipTests checkstyle:check ``` <details> <summary>Raw logs</summary> Before, on upstream `master` with the regression test: ```text Tests run: 1, Failures: 1, Errors: 0, Skipped: 0 AssertionFailedError: Expected warning hint about TRACK_EVENT_TIME_WATERMARK ... expected: <true> but was: <false> BUILD FAILURE ``` After: ```text Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 BUILD SUCCESS You have 0 Checkstyle violations. BUILD SUCCESS ``` </details> ### Contributor's checklist - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Enough context is provided in the sections above - [x] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
