wombatu-kun commented on code in PR #20487:
URL: https://github.com/apache/hudi/pull/20487#discussion_r4501382228
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/BootstrapExecutor.java:
##########
@@ -187,14 +187,15 @@ private void syncHive() {
private void initializeTable() throws IOException {
Path basePath = new Path(cfg.targetBasePath);
- if (fs.exists(basePath)) {
+ Path metaPath = new Path(cfg.targetBasePath,
HoodieTableMetaClient.METAFOLDER_NAME);
+ if (fs.exists(metaPath)) {
Review Comment:
With `.hoodie` present and `--bootstrap-overwrite` unset this no longer
throws, so bootstrapping onto an existing table goes on to `initTable`, which
overwrites that table's `hoodie.properties`. Please keep the `else` that throws
`Cannot bootstrap data on top of an existing table` here, with a test for it,
so only an empty directory gets the new pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
