yihua opened a new pull request, #19252: URL: https://github.com/apache/hudi/pull/19252
### Describe the issue this Pull Request addresses issue: #18623 Follow-up to the merged Vortex integration (#19182). A self-review of the merged code found two dispatch sites that miss the VORTEX case. ### Summary and Changelog - Add the missing `VORTEX` case to `HoodieFileReaderFactory#getFileReader(HoodieConfig, StoragePathInfo, HoodieFileFormat, Option)`, matching the `StoragePath` overload and the existing `LANCE` handling. Without it, a caller that starts from a listed `StoragePathInfo` gets `UnsupportedOperationException: VORTEX format not supported yet` instead of the Vortex reader. - Cover VORTEX in `CommonClientUtils`: `getLogBlockType` now maps VORTEX to `AVRO_DATA_BLOCK` (it previously fell to the default branch and threw `HoodieException: Base file format VORTEX does not have associated log block type`, breaking MOR log writes), and `shouldWriteNativeLogs` keeps VORTEX on the legacy inline log format like Lance until native log support for these formats is complete (it previously fell through to the write-version check and enabled the untested native-log path on table version 10). - Tests: `TestVortexReaderWriterRoundTrip#testFactoryStoragePathInfoDispatch` covers the factory overload end to end; `TestCommonClientUtils` gains a `getLogBlockType` parameterized test and VORTEX rows in the native-log expectations. - Clarify the `Spark3_5Adapter.createVortexFileReader` comment: the reason it returns `None` is that the adapter must stay compilable on the Java 11 Spark 3.5 CI builds where `SparkVortexReaderBase` is excluded, not the runtime JDK of Spark 3.5. ### Impact Fixes VORTEX dispatch gaps: base-file reads through the `StoragePathInfo` overload and MOR log-block writes on Vortex tables. Existing formats are unchanged; VORTEX MOR tables use the same inline Avro log blocks as Lance. ### Risk Level low ### Documentation Update none ### Contributor's checklist - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Enough context is provided in the sections above - [x] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
