nsivabalan commented on code in PR #20516:
URL: https://github.com/apache/hudi/pull/20516#discussion_r4593956420


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieStreamingSourceSafety.scala:
##########
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi.streaming
+
+import org.apache.hudi.{DataSourceReadOptions, DefaultSource, 
SparkAdapterSupport}
+import org.apache.hudi.common.model.WriteOperationType
+import org.apache.hudi.common.table.HoodieTableMetaClient
+import org.apache.hudi.common.table.timeline.{HoodieInstant, HoodieTimeline}
+import org.apache.hudi.common.util.CleanerUtils
+import org.apache.hudi.exception.HoodieException
+
+import org.apache.spark.{Partition, TaskContext}
+import org.apache.spark.rdd.RDD
+import org.apache.spark.sql.{DataFrame, SQLContext}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.execution.datasources.HadoopFsRelation
+import org.apache.spark.sql.types.StructType
+
+import scala.collection.JavaConverters._
+
+/** Conservative reset and history validation for checkpointed latest-state 
streaming consumers. */
+private[streaming] object HoodieStreamingSourceSafety extends 
SparkAdapterSupport {
+  private class RebuildRequired(message: String, cause: Throwable = null) 
extends HoodieException(message, cause)
+
+  // Spark re-plans the last committed batch on restart and discards it. Delay 
only safety
+  // rejections; healthy scans must remain visible to column pruning and 
predicate pushdown.
+  def deferRejection(sqlContext: SQLContext, schema: StructType)(batch: => 
DataFrame): DataFrame = {

Review Comment:
   `deferRejection(sqlContext: SQLContext, schema: StructType)` takes `schema` 
by value. The callers pass `schema`, which isn't memoized when `schemaOption` 
is empty, so every batch, healthy ones included, now resolves the table schema 
once more. `recover` already takes it by name; `schema: => StructType` here 
would match that.



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieStreamingSourceSafety.scala:
##########
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi.streaming
+
+import org.apache.hudi.{DataSourceReadOptions, DefaultSource, 
SparkAdapterSupport}
+import org.apache.hudi.common.model.WriteOperationType
+import org.apache.hudi.common.table.HoodieTableMetaClient
+import org.apache.hudi.common.table.timeline.{HoodieInstant, HoodieTimeline}
+import org.apache.hudi.common.util.CleanerUtils
+import org.apache.hudi.exception.HoodieException
+
+import org.apache.spark.{Partition, TaskContext}
+import org.apache.spark.rdd.RDD
+import org.apache.spark.sql.{DataFrame, SQLContext}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.execution.datasources.HadoopFsRelation
+import org.apache.spark.sql.types.StructType
+
+import scala.collection.JavaConverters._
+
+/** Conservative reset and history validation for checkpointed latest-state 
streaming consumers. */
+private[streaming] object HoodieStreamingSourceSafety extends 
SparkAdapterSupport {
+  private class RebuildRequired(message: String, cause: Throwable = null) 
extends HoodieException(message, cause)
+
+  // Spark re-plans the last committed batch on restart and discards it. Delay 
only safety
+  // rejections; healthy scans must remain visible to column pruning and 
predicate pushdown.
+  def deferRejection(sqlContext: SQLContext, schema: StructType)(batch: => 
DataFrame): DataFrame = {
+    try {
+      batch
+    } catch {
+      case error: RebuildRequired =>
+        val rows = new RDD[InternalRow](sqlContext.sparkContext, Nil) {
+          override protected def getPartitions: Array[Partition] = throw error
+
+          override def compute(split: Partition, context: TaskContext): 
Iterator[InternalRow] = throw error
+        }
+        sparkAdapter.internalCreateDataFrame(sqlContext.sparkSession, rows, 
schema, isStreaming = true)
+    }
+  }
+
+  def strategy(parameters: Map[String, String]): String = {
+    val config = DataSourceReadOptions.STREAMING_READ_RECOVERY_STRATEGY
+    val value = parameters.getOrElse(config.key(), config.defaultValue())
+    require(Set("FAIL", "READ_UPTO_LATEST_COMMIT", 
"READ_LATEST").contains(value),
+      s"Invalid ${config.key()}=$value; expected FAIL, READ_UPTO_LATEST_COMMIT 
or READ_LATEST")
+    value
+  }
+
+  def recover(sqlContext: SQLContext,
+              metaClient: HoodieTableMetaClient,
+              schema: => StructType,
+              parameters: Map[String, String],
+              strategy: String,
+              start: String,
+              end: String,
+              completionTime: Boolean,
+              resumed: Boolean): Option[DataFrame] = {
+    lazy val recoverySchema = schema
+    try {
+      validate(metaClient, start, end, completionTime, resumed)
+      None
+    } catch {
+      case error: RebuildRequired => strategy match {
+        case "FAIL" => throw error
+        case "READ_LATEST" =>
+          Some(sparkAdapter.internalCreateDataFrame(sqlContext.sparkSession,
+            sqlContext.sparkContext.emptyRDD[InternalRow], recoverySchema, 
isStreaming = true))
+        case "READ_UPTO_LATEST_COMMIT" =>
+          // Spark owns the batch end/checkpoint. Never read a newer snapshot 
and checkpoint an older end.
+          val timeline = metaClient.reloadActiveTimeline()
+          val writes = timeline.getCommitsTimeline.filterCompletedInstants()
+            .getInstants.asScala.toSeq
+          def offset(i: HoodieInstant): String = if (completionTime) 
i.getCompletionTime else i.requestedTime()
+          val included = writes.filter(i => offset(i) <= end)
+          val bound = included.map(_.requestedTime()).reduceOption((a, b) => 
if (a > b) a else b)
+          def isTableService(instant: HoodieInstant): Boolean = {
+            val operation = if (instant.getAction == 
HoodieTimeline.REPLACE_COMMIT_ACTION) {
+              timeline.readReplaceCommitMetadata(instant).getOperationType
+            } else {
+              timeline.readCommitMetadata(instant).getOperationType
+            }
+            Set(WriteOperationType.COMPACT, WriteOperationType.LOG_COMPACT, 
WriteOperationType.CLUSTER).contains(operation)
+          }
+          if (bound.isEmpty || writes.exists(i => offset(i) > end && 
i.requestedTime() <= bound.get && !isTableService(i))) {
+            throw new RebuildRequired("Cannot reconstruct the recovery 
snapshot at the checkpointed batch end. "
+              + "Rebuild downstream tables and checkpoints together.", error)
+          }
+          val options = parameters ++ Map(
+            DataSourceReadOptions.QUERY_TYPE.key() -> 
DataSourceReadOptions.QUERY_TYPE_SNAPSHOT_OPT_VAL,
+            DataSourceReadOptions.TIME_TRAVEL_AS_OF_INSTANT.key() -> bound.get)
+          val relation = DefaultSource.createRelation(sqlContext, metaClient, 
recoverySchema, options)
+          Some(relation match {
+            case fsRelation: HadoopFsRelation => 
sparkAdapter.createStreamingDataFrame(sqlContext, fsRelation, recoverySchema)
+            case _ => 
sparkAdapter.internalCreateDataFrame(sqlContext.sparkSession,
+              
sqlContext.baseRelationToDataFrame(relation).queryExecution.toRdd, 
recoverySchema, isStreaming = true)
+          })
+      }
+    }
+  }
+
+  def validate(metaClient: HoodieTableMetaClient,
+               start: String,
+               end: String,
+               completionTime: Boolean,
+               resumed: Boolean): Unit = {
+    if (start != HoodieTimeline.INIT_INSTANT_TS) {
+      validateRetainedRange(metaClient, start, end, completionTime, resumed)
+    }
+  }
+
+  private def validateRetainedRange(metaClient: HoodieTableMetaClient,
+                                    start: String,
+                                    end: String,
+                                    completionTime: Boolean,
+                                    resumed: Boolean): Unit = {
+    val timeline = metaClient.reloadActiveTimeline()
+    val completed = 
timeline.filterCompletedInstants().getInstants.asScala.toSeq
+    def offset(instant: HoodieInstant): String = {
+      if (completionTime) instant.getCompletionTime else 
instant.requestedTime()
+    }
+    def fail(reason: String): Nothing = {
+      throw new RebuildRequired(s"Streaming source rebuild required for 
${metaClient.getBasePath}: $reason. "
+        + "Stop downstream consumers and rebuild affected downstream tables 
and checkpoints in dependency order. "
+        + s"To explicitly accept recovery risks, set 
${DataSourceReadOptions.STREAMING_READ_RECOVERY_STRATEGY.key()} "
+        + "to READ_UPTO_LATEST_COMMIT (snapshot replay) or READ_LATEST (skip 
the gap).")
+    }
+
+    val checkpointInstant = completed.find(i => offset(i) == start)
+    if (resumed && checkpointInstant.isEmpty) {
+      fail(s"saved offset $start is absent from the active timeline; history 
expired or the source table was recreated")
+    }
+    if (end < start) {
+      fail(s"source offset moved backwards from $start to $end")
+    }
+
+    val firstWrite = 
timeline.getWriteTimeline.filterCompletedInstants().firstInstant()
+    val requestedStart = checkpointInstant.map(_.requestedTime())
+    val unreadWrites = 
timeline.getCommitsTimeline.filterCompletedInstants().getInstants.asScala
+      .filter(i => offset(i) > start && offset(i) <= end).toSeq
+    val earliestUnread = unreadWrites.map(_.requestedTime()).reduceOption((a, 
b) => if (a < b) a else b)
+    val completedByRequestedTime = completed.map(i => i.requestedTime() -> 
i).toMap
+    // Usually only new cleans matter. Retain earlier cleans for 
late-completing writes,
+    // or a user-specified initial offset whose requested-time boundary is 
unknown.
+    timeline.getCleanerTimeline.filterCompletedInstants().getInstants.asScala
+      .filter(clean => offset(clean) > start || requestedStart.isEmpty ||
+        requestedStart.exists(_ < clean.requestedTime()) || 
earliestUnread.exists(_ < clean.requestedTime()))
+      .foreach { clean =>
+        val metadata = CleanerUtils.getCleanerMetadata(metaClient, clean)
+        val retained = metadata.getEarliestCommitToRetain
+        // File-version cleaning does not expose a retention boundary. Refuse 
to infer safety.
+        if ((retained == null || retained.isEmpty) && 
metadata.getTotalFilesDeleted > 0 && offset(clean) > start) {
+          fail("the cleaner did not record an earliest retained commit; 
KEEP_LATEST_FILE_VERSIONS "
+            + "cannot prove incremental safety after deleting files")
+        }
+        val boundary = Option(retained).filter(_.nonEmpty)
+        val retainedInstant = completedByRequestedTime.get(retained)
+        val expired = boundary.exists { floor =>
+          earliestUnread.exists(_ < floor) ||
+            (requestedStart.isEmpty && retainedInstant.exists(i => start < 
offset(i))) ||
+            (requestedStart.isEmpty && retainedInstant.isEmpty && 
firstWrite.isPresent && start < offset(firstWrite.get))
+        }
+        if (expired) {
+          fail(s"history after offset $start has been cleaned (earliest 
retained commit $retained)")
+        }
+      }
+
+    completed.filter(i => i.getAction == HoodieTimeline.REPLACE_COMMIT_ACTION 
&&
+      offset(i) > start).foreach { instant =>
+      val operation = 
timeline.readReplaceCommitMetadata(instant).getOperationType
+      if (operation != WriteOperationType.CLUSTER) {

Review Comment:
   Agree with keeping this strict for this release. Please make the scope 
explicit, because "logical overwrite/truncate" in the docs doesn't tell users 
that these routine operations trip it:
   - **Partition TTL.** It is a Hudi table service that writes 
`DELETE_PARTITION` replacecommits (`SparkPartitionTTLActionExecutor`) and can 
run inline (`hoodie.partition.ttl.inline`). Enabling TTL on an upstream table 
stops every streaming consumer of it.
   - **Partition-level `INSERT OVERWRITE`**, the common idempotent partition 
reload (operation `INSERT_OVERWRITE`, not `INSERT_OVERWRITE_TABLE`).
   - **`delete_partition` writes.**
   
   Suggested changes:
   - Config description, `SOURCE_SAFETY.md` and the release note: say that the 
streaming source supports insert/upsert/delete plus compaction and clustering, 
and that `INSERT OVERWRITE` (table or partition), `delete_partition` and 
partition TTL on an upstream table require recovery for downstream consumers. 
Also note that `READ_LATEST` drops the overwrite's new rows, and 
`READ_UPTO_LATEST_COMMIT` replays the whole table.
   - Test: add a partition-level `insert_overwrite` (or `delete_partition`) 
case next to the existing `insert_overwrite_table` one, so the scope is pinned.



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieStreamingSourceSafety.scala:
##########
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi.streaming
+
+import org.apache.hudi.{DataSourceReadOptions, DefaultSource, 
SparkAdapterSupport}
+import org.apache.hudi.common.model.WriteOperationType
+import org.apache.hudi.common.table.HoodieTableMetaClient
+import org.apache.hudi.common.table.timeline.{HoodieInstant, HoodieTimeline}
+import org.apache.hudi.common.util.CleanerUtils
+import org.apache.hudi.exception.HoodieException
+
+import org.apache.spark.{Partition, TaskContext}
+import org.apache.spark.rdd.RDD
+import org.apache.spark.sql.{DataFrame, SQLContext}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.execution.datasources.HadoopFsRelation
+import org.apache.spark.sql.types.StructType
+
+import scala.collection.JavaConverters._
+
+/** Conservative reset and history validation for checkpointed latest-state 
streaming consumers. */
+private[streaming] object HoodieStreamingSourceSafety extends 
SparkAdapterSupport {
+  private class RebuildRequired(message: String, cause: Throwable = null) 
extends HoodieException(message, cause)
+
+  // Spark re-plans the last committed batch on restart and discards it. Delay 
only safety
+  // rejections; healthy scans must remain visible to column pruning and 
predicate pushdown.
+  def deferRejection(sqlContext: SQLContext, schema: StructType)(batch: => 
DataFrame): DataFrame = {
+    try {
+      batch
+    } catch {
+      case error: RebuildRequired =>
+        val rows = new RDD[InternalRow](sqlContext.sparkContext, Nil) {
+          override protected def getPartitions: Array[Partition] = throw error
+
+          override def compute(split: Partition, context: TaskContext): 
Iterator[InternalRow] = throw error
+        }
+        sparkAdapter.internalCreateDataFrame(sqlContext.sparkSession, rows, 
schema, isStreaming = true)
+    }
+  }
+
+  def strategy(parameters: Map[String, String]): String = {
+    val config = DataSourceReadOptions.STREAMING_READ_RECOVERY_STRATEGY
+    val value = parameters.getOrElse(config.key(), config.defaultValue())
+    require(Set("FAIL", "READ_UPTO_LATEST_COMMIT", 
"READ_LATEST").contains(value),
+      s"Invalid ${config.key()}=$value; expected FAIL, READ_UPTO_LATEST_COMMIT 
or READ_LATEST")
+    value
+  }
+
+  def recover(sqlContext: SQLContext,
+              metaClient: HoodieTableMetaClient,
+              schema: => StructType,
+              parameters: Map[String, String],
+              strategy: String,
+              start: String,
+              end: String,
+              completionTime: Boolean,
+              resumed: Boolean): Option[DataFrame] = {
+    lazy val recoverySchema = schema
+    try {
+      validate(metaClient, start, end, completionTime, resumed)
+      None
+    } catch {
+      case error: RebuildRequired => strategy match {
+        case "FAIL" => throw error
+        case "READ_LATEST" =>
+          Some(sparkAdapter.internalCreateDataFrame(sqlContext.sparkSession,
+            sqlContext.sparkContext.emptyRDD[InternalRow], recoverySchema, 
isStreaming = true))
+        case "READ_UPTO_LATEST_COMMIT" =>
+          // Spark owns the batch end/checkpoint. Never read a newer snapshot 
and checkpoint an older end.
+          val timeline = metaClient.reloadActiveTimeline()
+          val writes = timeline.getCommitsTimeline.filterCompletedInstants()
+            .getInstants.asScala.toSeq
+          def offset(i: HoodieInstant): String = if (completionTime) 
i.getCompletionTime else i.requestedTime()
+          val included = writes.filter(i => offset(i) <= end)
+          val bound = included.map(_.requestedTime()).reduceOption((a, b) => 
if (a > b) a else b)
+          def isTableService(instant: HoodieInstant): Boolean = {
+            val operation = if (instant.getAction == 
HoodieTimeline.REPLACE_COMMIT_ACTION) {
+              timeline.readReplaceCommitMetadata(instant).getOperationType
+            } else {
+              timeline.readCommitMetadata(instant).getOperationType
+            }
+            Set(WriteOperationType.COMPACT, WriteOperationType.LOG_COMPACT, 
WriteOperationType.CLUSTER).contains(operation)
+          }
+          if (bound.isEmpty || writes.exists(i => offset(i) > end && 
i.requestedTime() <= bound.get && !isTableService(i))) {

Review Comment:
   Minor, non-blocking: **a reset that completes after `end` gives two full 
snapshots under `READ_UPTO_LATEST_COMMIT`.** This happens when a query restarts 
and re-runs an uncommitted batch whose recorded end predates an overwrite made 
during downtime. Batch N is rejected because of a replacecommit beyond `end`, 
so it snapshots the pre-reset table at `bound`. Batch N+1 then contains the 
replacecommit and snapshots again. An append target gets the table twice. Worth 
a sentence in `SOURCE_SAFETY.md`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to