cshuo commented on code in PR #20666:
URL: https://github.com/apache/hudi/pull/20666#discussion_r4594390868


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -130,7 +130,8 @@ public class HoodieStorageConfig extends HoodieConfig {
       .defaultValue(true)
       .markAdvanced()
       .sinceVersion("1.3.0")
-      .withDocumentation("Control whether to write bloom filter or not to 
HFile.");
+      .withDocumentation("Control whether to write bloom filter or not to 
HFile. The metadata table writes it only when "
+          + "hoodie.metadata.bloom.filter.enable is also set, as its lookups 
only read the bloom filter then.");

Review Comment:
   Could we keep bloom filter generation controlled by a write setting, 
independently of the reader setting? If writing bloom filters should be 
disabled by default, could we change the write-side default at the intended 
scope instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to