danny0405 commented on code in PR #20671:
URL: https://github.com/apache/hudi/pull/20671#discussion_r4594763765
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataFileWriterFactory.java:
##########
@@ -102,7 +102,7 @@ public HoodieFileWriter newParquetFileWriter(
HoodieConfig hoodieConfig = injectedConfigs.getRight();
Configuration conf = (Configuration)
storageConfiguration.unwrapAs(Configuration.class);
- BloomFilter filter = enableBloomFilter(metaFieldsMode, hoodieConfig) ?
createBloomFilter(hoodieConfig) : null;
+ BloomFilter filter = enableParquetBloomFilter(metaFieldsMode,
hoodieConfig, storagePath) ? createBloomFilter(hoodieConfig) : null;
Review Comment:
can we override the BF enabling/disabling flag for native log format writer
instead of checking the file path in multiple places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]