prathik-onehouse opened a new pull request, #20682:
URL: https://github.com/apache/hudi/pull/20682

   ### Describe the issue this Pull Request addresses
   
   Closes #20681
   
   Hudi 0.x and 1.0.x, the readers of tables at versions 6 and 8, take 
`hoodie.table.precombine.field` as one field name, so a table below version 9 
cannot carry several ordering fields for them. Stacked on #20346, review that 
first.
   
   ### Summary and Changelog
   
   `HoodieTableConfig.create` refuses a table below version 9 that declares 
more than one ordering field, with `HoodieNotSupportedException`, before 
`hoodie.properties` is created, so a refused create leaves no empty properties 
file behind. `TestHoodieTableMetaClient` covers the refusal at versions 6, 7 
and 8 and a version 9 table that keeps both fields; the two-field rows of the 
MySQL Debezium test are dropped since that case is now refused.
   
   ### Impact
   
   Creating a table below version 9 with several ordering fields now fails, 
with a message naming the fields and pointing to a single field or version 9. 
Tables at version 9 and above, and tables with one ordering field, behave as 
before.
   
   ### Risk Level
   
   low
   
   Only `HoodieTableConfig.create` changes. Existing tables below version 9 
with several ordering fields are not refused on write by this change, and the 9 
to 8 downgrade is handled in #20348. Because table re-creation from existing 
properties also goes through `create`, `ALTER TABLE RENAME`, the repair-props 
commands and `TRUNCATE TABLE` are refused on such an existing table; `TRUNCATE 
TABLE` deletes the table directory before re-creating `hoodie.properties`, so 
it leaves that table without one.
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] fix(core): refuse several ... prathik-onehouse (via GitHub) via commits

Reply via email to