Davis-Zhang-Onehouse opened a new pull request, #20698:
URL: https://github.com/apache/hudi/pull/20698

   ### Describe the issue this Pull Request addresses
   
   issue: #20697
   Part of #20683, RFC-118 (#20684).
   Stacked on #20696: review only the last commit. Until the PRs below it 
merge, this PR also shows their commits.
   
   Adds the PDF chunker and prep-work balancing of the RFC-118 embedding stream.
   
   ### Summary and Changelog
   
   - PDF: `PdfChunker` / `PdfBoxChunker`, `PdfBoxPageSource`, `PageSource` / 
`PageSourceFactory`, `PageText`, `GuardedPageStripper`, `BoundedPageWriter`, 
`PdfChunkIterator`, `PdfChunk`, `PdfChunkerConfig`, `PdfFilePreprocessor`, PDF 
failure codes (`PdfFailureCode`, `PdfFileFailure`), and scratch-file handling 
(`PdfBoxScratchCache`, `ScratchFiles`).
   - Preprocessing: `PreprocessorRegistry` and `PreprocessingIterator`.
   - Balancing: `RowBalancer` with `RowBalancingStrategy`, 
`HashBalancingStrategy` and `AssignmentBalancingStrategy` (`BalancedRows`, 
`BalancingAssignment`, `ExactPartitioner`, `HashSpread`, `SortedRanks`).
   - `EmbeddingTableConfig`: the balancing settings document the hash strategy 
as the default; `ChunkIdScheme`: a Javadoc correction.
   - 13 test files.
   
   Only files added earlier in this chain are modified. PDFBox and its 
attribution came with the embedding table core PR. No code was copied from 
other projects.
   
   Known limitation, fixed later in this chain before it completes: PDF 
extraction, normalization and packing keep whole-page strings, so retained text 
grows with page size instead of being capped by the chunk window.
   
   ### Impact
   
   New PDF preprocessing and balancing for the embedding stream; no change to 
existing features.
   
   ### Risk Level
   
   low: new code paths only. Verified on JDK 11 / Spark 3.5 / Scala 2.12 with 
94 tests, module compilation, checkstyle and RAT.
   
   ### Documentation Update
   
   The balancing settings' config documentation is updated; a website page 
follows once the chain lands.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] feat(ingest): RFC-118: ... Davis-Zhang-Onehouse (via GitHub) via commits

Reply via email to