farisbasha opened a new pull request, #20745:
URL: https://github.com/apache/hudi/pull/20745

   ### Describe the issue this Pull Request addresses
   
   Three config descriptions name config keys that do not exist, so a user who 
copies them sets a key that Hudi ignores:
   
   1. `HoodieMetadataConfig.BLOOM_FILTER_FPP` 
(`hoodie.metadata.bloom.filter.fpp`) says the fpp may not be honored if more 
entries are added than "the configured value 
(`hoodie.metadata.bloom.num_entries`)". That key does not exist; the property 
defined a few lines above is `BLOOM_FILTER_NUM_ENTRIES` = 
`hoodie.metadata.bloom.filter.num.entries`. (The same sentence in 
`HoodieStorageConfig` correctly refers to `hoodie.index.bloom.num_entries`, 
which may be where the name came from.)
   2. `CloudSourceConfig.BATCH_SIZE_CONF` names 
`hoodie.streamer.source.cloud.meta.max.fetch.time.per.sync.ms`, but the key 
defined in the same class (`MAX_FETCH_TIME_PER_SYNC_SECS`) is 
`hoodie.streamer.source.cloud.meta.max.fetch.time.per.sync.secs`. The same 
description also concatenates `...max.num.messages.per.sync` and `from` without 
a space, so the rendered text reads `per.syncfrom`.
   3. `CloudSourceConfig.SPARK_DATASOURCE_OPTIONS` 
(`hoodie.streamer.source.cloud.data.datasource.options`) gives the example 
`hoodie.streamer.gcp.spark.datasource.options={...}`. No such key is defined 
anywhere in the repository; the example now uses the property's own key. The 
same example in the javadoc of the deprecated 
`CloudStoreIngestionConfig.SPARK_DATASOURCE_OPTIONS` constant (which is 
`CloudSourceConfig.SPARK_DATASOURCE_OPTIONS.key()`) is updated too.
   
   ### Summary and Changelog
   
   Documentation strings only:
   - `HoodieMetadataConfig`: `hoodie.metadata.bloom.num_entries` -> 
`hoodie.metadata.bloom.filter.num.entries` in the `BLOOM_FILTER_FPP` 
description.
   - `CloudSourceConfig`: `...max.fetch.time.per.sync.ms` -> 
`...max.fetch.time.per.sync.secs` and a missing space in the `BATCH_SIZE_CONF` 
description; example key in the `SPARK_DATASOURCE_OPTIONS` description.
   - `CloudStoreIngestionConfig`: same example key in a javadoc comment.
   
   ### Impact
   
   None on behavior; the config descriptions now name keys that exist.
   
   ### Risk Level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable (n/a, description strings only)
   
   This was found with the help of an AI assistant.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to