This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch 
gh-readonly-queue/master/pr-20745-6037444c385bb36394eff4d134926882eb103a60
in repository https://gitbox.apache.org/repos/asf/hudi.git

commit b9426d7963ff4a4bda29548067687015ee7b819a
Author: Faris Basha TM <[email protected]>
AuthorDate: Thu Nov 19 02:14:00 2026 +0000

    docs: fix config keys named in bloom filter and cloud source config docs 
(#20745)
    
    * docs: fix config keys named in bloom filter and cloud source config docs
    
    * docs: build bloom fpp description from the key
    
    Use BLOOM_FILTER_NUM_ENTRIES.key() in the BLOOM_FILTER_FPP description
    instead of a literal, so the named key cannot drift from the declared
    one again. The rendered text is unchanged.
    
    ---------
    
    Co-authored-by: voon <[email protected]>
---
 .../java/org/apache/hudi/common/config/HoodieMetadataConfig.java    | 2 +-
 .../java/org/apache/hudi/utilities/config/CloudSourceConfig.java    | 6 +++---
 .../hudi/utilities/sources/helpers/CloudStoreIngestionConfig.java   | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
index 619fb7c55876..24f95eba3c41 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
@@ -676,7 +676,7 @@ public final class HoodieMetadataConfig extends 
HoodieConfig {
           + "metadata table. This is used to calculate how many bits should be 
assigned for the bloom filter "
           + "and the number of hash functions. This is usually set very low 
(default: 0.000000001), "
           + "we like to tradeoff disk space for lower false positives. If the 
number of entries "
-          + "added to bloom filter exceeds the configured value 
(hoodie.metadata.bloom.num_entries), "
+          + "added to bloom filter exceeds the configured value (" + 
BLOOM_FILTER_NUM_ENTRIES.key() + "), "
           + "then this fpp may not be honored.");
 
   public static final ConfigProperty<String> BLOOM_FILTER_DYNAMIC_MAX_ENTRIES 
= ConfigProperty
diff --git 
a/hudi-utilities/src/main/java/org/apache/hudi/utilities/config/CloudSourceConfig.java
 
b/hudi-utilities/src/main/java/org/apache/hudi/utilities/config/CloudSourceConfig.java
index e46c2bba12c8..b1ae0dac113c 100644
--- 
a/hudi-utilities/src/main/java/org/apache/hudi/utilities/config/CloudSourceConfig.java
+++ 
b/hudi-utilities/src/main/java/org/apache/hudi/utilities/config/CloudSourceConfig.java
@@ -54,8 +54,8 @@ public class CloudSourceConfig extends HoodieConfig {
       .withAlternatives(DELTA_STREAMER_CONFIG_PREFIX + 
"source.cloud.meta.batch.size")
       .markAdvanced()
       .withDocumentation("Number of metadata messages to pull in one API call 
to the cloud events queue. "
-          + "Multiple API calls with this batch size are sent to cloud events 
queue, until we consume 
hoodie.streamer.source.cloud.meta.max.num.messages.per.sync"
-          + "from the queue or 
hoodie.streamer.source.cloud.meta.max.fetch.time.per.sync.ms amount of time has 
passed or queue is empty. ");
+          + "Multiple API calls with this batch size are sent to cloud events 
queue, until we consume 
hoodie.streamer.source.cloud.meta.max.num.messages.per.sync "
+          + "from the queue or 
hoodie.streamer.source.cloud.meta.max.fetch.time.per.sync.secs amount of time 
has passed or queue is empty. ");
 
   public static final ConfigProperty<Integer> META_EVENTS_PER_PARTITION = 
ConfigProperty
       .key(STREAMER_CONFIG_PREFIX + "source.cloud.meta.events.per.partition")
@@ -124,7 +124,7 @@ public class CloudSourceConfig extends HoodieConfig {
       .withAlternatives(DELTA_STREAMER_CONFIG_PREFIX + 
"source.cloud.data.datasource.options")
       .markAdvanced()
       .withDocumentation("A JSON string passed to the Spark DataFrameReader 
while loading the dataset. "
-          + "Example: 
`hoodie.streamer.gcp.spark.datasource.options={\"header\":\"true\",\"encoding\":\"UTF-8\"}`\n");
+          + "Example: 
`hoodie.streamer.source.cloud.data.datasource.options={\"header\":\"true\",\"encoding\":\"UTF-8\"}`\n");
 
   public static final ConfigProperty<String> CLOUD_DATAFILE_EXTENSION = 
ConfigProperty
       .key(STREAMER_CONFIG_PREFIX + "source.cloud.data.select.file.extension")
diff --git 
a/hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/CloudStoreIngestionConfig.java
 
b/hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/CloudStoreIngestionConfig.java
index 8a1c15c88869..b367d152d671 100644
--- 
a/hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/CloudStoreIngestionConfig.java
+++ 
b/hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/CloudStoreIngestionConfig.java
@@ -84,7 +84,7 @@ public class CloudStoreIngestionConfig {
 
   /**
    * A JSON string passed to the Spark DataFrameReader while loading the 
dataset.
-   * Example: 
hoodie.streamer.gcp.spark.datasource.options={"header":"true","encoding":"UTF-8"}
+   * Example: 
hoodie.streamer.source.cloud.data.datasource.options={"header":"true","encoding":"UTF-8"}
    */
   @Deprecated
   public static final String SPARK_DATASOURCE_OPTIONS = 
CloudSourceConfig.SPARK_DATASOURCE_OPTIONS.key();

Reply via email to