voonhous commented on code in PR #19933:
URL: https://github.com/apache/hudi/pull/19933#discussion_r4625789016
##########
.github/workflows/bot.yml:
##########
@@ -325,18 +326,47 @@ jobs:
FLINK_PROFILE: ${{ matrix.flinkProfile }}
run:
mvn test -Pfunctional-tests -D"$SCALA_PROFILE" -D"$SPARK_PROFILE"
-D"$FLINK_PROFILE" -fae -Dsurefire.failIfNoSpecifiedTests=false -pl
hudi-utilities $MVN_ARGS -Djacoco.skip=false
+ # These modules had a job of their own, so a hudi-utilities test failure
must not skip them.
+ - name: UT - hudi-hadoop-mr and hudi-client/hudi-java-client
+ if: ${{ !cancelled() && steps.build.outcome == 'success' }}
+ env:
+ SCALA_PROFILE: ${{ matrix.scalaProfile }}
+ SPARK_PROFILE: ${{ matrix.sparkProfile }}
+ FLINK_PROFILE: ${{ matrix.flinkProfile }}
+ run:
+ mvn test -Punit-tests -fae -D"$SCALA_PROFILE" -D"$SPARK_PROFILE"
-D"$FLINK_PROFILE" -pl hudi-hadoop-mr,hudi-client/hudi-java-client $MVN_ARGS
-Djacoco.skip=false
- name: Test timing summary
if: always()
run: python3 scripts/ci/test_timing_summary.py --title "${{ github.job
}}"
- - name: Generate merged coverage report
+ # One report per flag, each from its own modules' exec files, so each
flag keeps the coverage
+ # of its own tests. Each report is uploaded before the next call
replaces it.
+ - name: Generate hudi-utilities coverage report
if: always() && github.event_name != 'merge_group'
- run: ./scripts/jacoco/generate_merged_coverage_report.sh
$GITHUB_WORKSPACE
- - name: Upload coverage to Codecov
+ run: ./scripts/jacoco/generate_merged_coverage_report.sh
$GITHUB_WORKSPACE $GITHUB_WORKSPACE/hudi-utilities
+ - name: Upload hudi-utilities coverage to Codecov
if: always() && github.event_name != 'merge_group'
uses: ./.github/actions/upload-coverage
with:
flags: utilities
token: ${{ secrets.CODECOV_TOKEN }}
+ # Classes and sources come from the reactor this flag's job built on its
own (hudi-hadoop-mr,
+ # hudi-java-client and their upstream modules), so hudi-utilities'
classes stay out of its report.
+ # exec-maven-plugin is pinned to the version the repo's poms already use.
+ - name: Generate hudi-hadoop-mr and hudi-java-client coverage report
+ if: always() && github.event_name != 'merge_group'
+ env:
+ SCALA_PROFILE: ${{ matrix.scalaProfile }}
+ SPARK_PROFILE: ${{ matrix.sparkProfile }}
+ FLINK_PROFILE: ${{ matrix.flinkProfile }}
+ run: |
+ module_dirs=$(mvn -q -B -ntp -D"$SCALA_PROFILE" -D"$SPARK_PROFILE"
-D"$FLINK_PROFILE" -Phudi-platform-service -am -pl
hudi-hadoop-mr,hudi-client/hudi-java-client
org.codehaus.mojo:exec-maven-plugin:1.6.0:exec -Dexec.executable=pwd)
Review Comment:
Fixed: the step now runs `rm -f jacoco-report.xml` before the Maven command,
so if reactor discovery fails there is no report left for the `always()`
upload. A missing file is already handled there: Codecov skips without failing
and the fork artifact upload has `if-no-files-found: ignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]