leesf commented on a change in pull request #2761:
URL: https://github.com/apache/hudi/pull/2761#discussion_r614768558
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkUpsertCommitActionExecutor.java
##########
@@ -44,6 +44,7 @@ public
SparkUpsertCommitActionExecutor(HoodieSparkEngineContext context,
@Override
public HoodieWriteMetadata<JavaRDD<WriteStatus>> execute() {
return SparkWriteHelper.newInstance().write(instantTime, inputRecordsRDD,
context, table,
- config.shouldCombineBeforeUpsert(),
config.getUpsertShuffleParallelism(), this, true);
+ config.shouldCombineBeforeUpsert(),
config.getUpsertShuffleParallelism(),
+ this,
Boolean.parseBoolean(config.getProps().getProperty("hoodie.tagging.before.insert",
"true")));
Review comment:
would you move `hoodie.tagging.before.insert` and default value to
HoodieWriteConfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
