voonhous opened a new pull request, #20765:
URL: https://github.com/apache/hudi/pull/20765

   ### Describe the issue this Pull Request addresses
   
   Some classes in `hudi-hadoop-mr` still declare their logger by hand (`static 
final Logger LOG = LoggerFactory.getLogger(...)`) instead of the Lombok 
`@Slf4j` annotation the codebase has standardized on. This PR migrates them. 
Continues #19190 (flink) of the logging cleanup.
   
   ### Summary and Changelog
   
   - Per file: add `@Slf4j`, delete the `LOG` field and the `org.slf4j.Logger` 
/ `org.slf4j.LoggerFactory` imports, and rename `LOG` -> `log` (Lombok 
generates a lowercase `log`).
   - Migrated 23 main classes.
   - `RealtimeCompactedRecordReader` logged under its parent class, so it uses 
`@Slf4j(topic = 
"org.apache.hudi.hadoop.realtime.AbstractRealtimeRecordReader")` to keep the 
category.
   - `HoodieColumnProjectionUtils` declared its logger under Hive's 
`ColumnProjectionUtils` but never used it; it now uses plain `@Slf4j`.
   - The six public `LOG` fields removed here have no references outside their 
own class.
   
   ### Impact
   
   none - the Lombok-generated logger has the same category as the 
hand-declared one, so log output is unchanged.
   
   ### Risk Level
   
   low - mechanical rename, no logic change.
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to