voonhous opened a new pull request, #20767:
URL: https://github.com/apache/hudi/pull/20767

   ### Describe the issue this Pull Request addresses
   
   Some classes in `hudi-common` still declare their logger by hand (`static 
final Logger LOG = LoggerFactory.getLogger(...)`) instead of the Lombok 
`@Slf4j` annotation the codebase has standardized on. This PR migrates them. 
Continues #19190 (flink) of the logging cleanup.
   
   ### Summary and Changelog
   
   - Per file: add `@Slf4j`, delete the `LOG` field and the `org.slf4j.Logger` 
/ `org.slf4j.LoggerFactory` imports, and rename `LOG` -> `log` (Lombok 
generates a lowercase `log`).
   - Migrated 11 classes (8 main, 3 test).
   - `ArchivedTimelineV1` / `ArchivedTimelineV2` log under the 
`HoodieArchivedTimeline` interface they implement, so they use `@Slf4j(topic = 
...)` to keep the category.
   - `TableMetadataFactory.LOG` was only used by its subclass 
`NativeTableMetadataFactory`, which now gets its own `@Slf4j`.
   - Left hand-declared: `HoodieTableMetadata` (interface, `@Slf4j` is 
class-only), `SamplingLogger` (dynamic logger name), 
`BaseHoodieQueueBasedExecutor` (instance logger from `getClass()`).
   
   ### Impact
   
   Only one `warn` line in `NativeTableMetadataFactory` changes logger category 
(from `TableMetadataFactory` to its own class). Everything else is unchanged.
   
   ### Risk Level
   
   low - mechanical rename, no logic change.
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to