zhedoubushishi commented on pull request #2833: URL: https://github.com/apache/hudi/pull/2833#issuecomment-822659476
> this PR looks good. We can do the other config classes as well and land this. > > a) Can we also tackle `HoodieTableConfig` in this PR? > > b) For this comment, the fix is simple. just adding a `.key()` when upgrading versions. So should be ok? > > > > The disadvantage is for users who are now using e.g. HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP in their client code, they need to either replace it with HoodieBootstrapConfig.BOOTSTRAP_BASE_PATH_PROP or hoodie.bootstrap.base.path. ````HoodieTableConfig``` is also something I thinked about. I perfer to try to make it be consistent with other option classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
