vinothchandar commented on a change in pull request #2819:
URL: https://github.com/apache/hudi/pull/2819#discussion_r616215766



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -73,6 +71,16 @@
   private static final Logger LOG = 
LogManager.getLogger(HoodieActiveTimeline.class);
   protected HoodieTableMetaClient metaClient;
   private static AtomicReference<String> lastInstantTime = new 
AtomicReference<>(String.valueOf(Integer.MIN_VALUE));
+  private static ThreadLocal<SimpleDateFormat> commitFormatHolder = new 
ThreadLocal<SimpleDateFormat>() {

Review comment:
       +1 @prashantwason . Introducing a thread local for this scenario seems 
like an overkill? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to