xiarixiaoyao commented on a change in pull request #2858:
URL: https://github.com/apache/hudi/pull/2858#discussion_r617286940
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java
##########
@@ -239,7 +239,7 @@ public static HoodieDefaultTimeline
filterInstantsTimeline(HoodieDefaultTimeline
* those partitions.
*/
for (Path path : inputPaths) {
- if (path.toString().contains(s)) {
Review comment:
we should not use contains function.
for exmaple： inputPaths is “/tmp/huditable/111”
all affect paths are: “/tmp/huditable/1”, “/tmp/huditable/11”,
“/tmp/huditable/111”
“/tmp/huditable/1”, “/tmp/huditable/11” should be excluded. but if we
use contains function “/tmp/huditable/1”, “/tmp/huditable/11” will be
included. this is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
