jsbali commented on a change in pull request #2809:
URL: https://github.com/apache/hudi/pull/2809#discussion_r619816328



##########
File path: 
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java
##########
@@ -438,11 +437,20 @@ public static HoodieMetadataConfig 
buildMetadataConfig(Configuration conf) {
         if (LOG.isDebugEnabled()) {
           LOG.debug("Hoodie Metadata initialized with completed commit instant 
as :" + metaClient);
         }
-
         HoodieTimeline timeline = 
HoodieHiveUtils.getTableTimeline(metaClient.getTableConfig().getTableName(), 
job, metaClient);
+

Review comment:
       Yes that is great idea. I have made the changes accordingly

##########
File path: 
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java
##########
@@ -438,11 +437,20 @@ public static HoodieMetadataConfig 
buildMetadataConfig(Configuration conf) {
         if (LOG.isDebugEnabled()) {
           LOG.debug("Hoodie Metadata initialized with completed commit instant 
as :" + metaClient);
         }
-
         HoodieTimeline timeline = 
HoodieHiveUtils.getTableTimeline(metaClient.getTableConfig().getTableName(), 
job, metaClient);
+

Review comment:
       Yes, that is a good idea.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to