vinothchandar commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r622686509
########## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/UuidKeyGenerator.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.keygen; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.UUID; +import java.util.stream.Collectors; +import org.apache.avro.generic.GenericRecord; +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.keygen.constant.KeyGeneratorOptions; + +/** + * A KeyGenerator which use the uuid as the record key. + */ +public class UuidKeyGenerator extends BuiltinKeyGenerator { Review comment: I have a better suggestion. Could you try and explore time-ordered UUIDs instead? https://www.percona.com/blog/2014/12/19/store-uuid-optimized-way/ https://github.com/f4b6a3/uuid-creator This will do I think. We need not make changes to pass in commit time per se. I was using that as an example. It will be good to do this in first go itself, that way users don't have to regenerate/rewrite datasets ########## File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/MultiPartKeysValueExtractor.java ########## @@ -31,6 +32,11 @@ @Override public List<String> extractPartitionValuesInPath(String partitionPath) { + // If the partitionPath is empty string( which means none-partition table), the partition values Review comment: 2876 looks good. merged. ########## File path: pom.xml ########## @@ -112,6 +112,7 @@ <spark3.version>3.0.0</spark3.version> <spark2bundle.version></spark2bundle.version> <spark3bundle.version>3</spark3bundle.version> + <hudi.spark.moudle>hudi-spark2</hudi.spark.moudle> Review comment: rename this to `hudi.spark.module` ? There is a typo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
