vinothchandar commented on a change in pull request #2714:
URL: https://github.com/apache/hudi/pull/2714#discussion_r628821382
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -113,7 +113,9 @@ protected HoodieActiveTimeline(HoodieTableMetaClient
metaClient, Set<String> inc
// multiple casts will make this lambda serializable -
// http://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.16
this.details = (Function<HoodieInstant, Option<byte[]>> & Serializable)
this::getInstantDetails;
- LOG.info("Loaded instants " + getInstants().collect(Collectors.toList()));
+ if (LOG.isDebugEnabled()) {
Review comment:
This is actually a helpful debug aid, to tell us what the state of the
timeline was. So I am changing this to print the last instant , while moving it
back to INFO
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
##########
@@ -271,15 +271,15 @@ private void ensurePartitionLoadedCorrectly(String
partition) {
if (!isPartitionAvailableInStore(partitionPathStr)) {
// Not loaded yet
try {
- LOG.info("Building file system view for partition (" +
partitionPathStr + ")");
+ LOG.debug("Building file system view for partition (" +
partitionPathStr + ")");
Review comment:
this is actually good to keep IMO.
##########
File path:
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java
##########
@@ -135,7 +135,7 @@ private boolean syncIfLocalViewBehind(Context ctx) {
synchronized (view) {
if (isLocalViewBehind(ctx)) {
HoodieTimeline localTimeline =
viewManager.getFileSystemView(basePath).getTimeline();
- LOG.info("Syncing view as client passed last known instant " +
lastKnownInstantFromClient
+ LOG.debug("Syncing view as client passed last known instant " +
lastKnownInstantFromClient
Review comment:
this is again rather important. Going to just have the last instant
printed out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
