danny0405 commented on a change in pull request #2899:
URL: https://github.com/apache/hudi/pull/2899#discussion_r630684679
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineServerHelper.java
##########
@@ -35,16 +35,23 @@
private static final Logger LOG =
LogManager.getLogger(EmbeddedTimelineService.class);
+ private static Option<EmbeddedTimelineService> timelineServer;
+
/**
* Instantiate Embedded Timeline Server.
* @param context Hoodie Engine Context
* @param config Hoodie Write Config
* @return TimelineServer if configured to run
* @throws IOException
*/
- public static Option<EmbeddedTimelineService> createEmbeddedTimelineService(
+ public static synchronized Option<EmbeddedTimelineService>
createEmbeddedTimelineService(
HoodieEngineContext context, HoodieWriteConfig config) throws
IOException {
- Option<EmbeddedTimelineService> timelineServer = Option.empty();
+ if (timelineServer != null
Review comment:
Nice catch ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
