nsivabalan commented on a change in pull request #2927:
URL: https://github.com/apache/hudi/pull/2927#discussion_r632976739
##########
File path:
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/AvroConversionHelper.scala
##########
@@ -343,25 +350,67 @@ object AvroConversionHelper {
case structType: StructType =>
val schema: Schema = convertStructTypeToAvroSchema(structType,
structName, recordNamespace)
val childNameSpace = if (recordNamespace != "")
s"$recordNamespace.$structName" else structName
- val fieldConverters = structType.fields.map(field =>
- createConverterToAvro(
- field.dataType,
- field.name,
- childNameSpace))
- (item: Any) => {
- if (item == null) {
- null
- } else {
- val record = new Record(schema)
- val convertersIterator = fieldConverters.iterator
- val fieldNamesIterator =
dataType.asInstanceOf[StructType].fieldNames.iterator
- val rowIterator = item.asInstanceOf[Row].toSeq.iterator
+ if (honorSchemaMismatch) {
Review comment:
there are few lines that could be common among existing code flow and
new code flow in this code block of interest. but I did not want to do if else
line by line. and hence a big if else for old code path and new code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
