vinothchandar commented on a change in pull request #2899:
URL: https://github.com/apache/hudi/pull/2899#discussion_r638986316
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineServerHelper.java
##########
@@ -35,16 +35,22 @@
private static final Logger LOG =
LogManager.getLogger(EmbeddedTimelineService.class);
+ private static Option<EmbeddedTimelineService> timelineServer =
Option.empty();
Review comment:
@danny0405 there is a bit of a side-effect with assigning to this member
when `isEmbeddedTimelineServerReuseEnabled= false` . Holding a reference here
might mean, that the object wont be garbage collected?
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineServerHelper.java
##########
@@ -35,16 +35,22 @@
private static final Logger LOG =
LogManager.getLogger(EmbeddedTimelineService.class);
+ private static Option<EmbeddedTimelineService> timelineServer =
Option.empty();
Review comment:
can we name this `TIMELINE_SERVER`, consistent with static members?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
