wangxianghu commented on a change in pull request #3006:
URL: https://github.com/apache/hudi/pull/3006#discussion_r641884136



##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -242,7 +242,9 @@ public static TypedProperties 
flinkConf2TypedProperties(Configuration conf) {
         properties.put(option.key(), option.defaultValue());
       }
     }
-    return new TypedProperties(properties);
+    TypedProperties typeProps = new TypedProperties();
+    typeProps.putAll(typeProps);

Review comment:
       hi, @hk-lrzy thanks for your contribution.
   There might be a mistake here , do you mean ` typeProps.putAll(properties)`?
   
   BTW, I tried this method, it seems ok?
   you can try 
`org.apache.hudi.common.config.TypedProperties#getString(java.lang.String)`,  
the value you set do exists.
   the problem might be the `toString()` method shows no values, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to