hk-lrzy commented on a change in pull request #3006:
URL: https://github.com/apache/hudi/pull/3006#discussion_r642469666



##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -242,7 +242,9 @@ public static TypedProperties 
flinkConf2TypedProperties(Configuration conf) {
         properties.put(option.key(), option.defaultValue());
       }
     }
-    return new TypedProperties(properties);
+    TypedProperties typeProps = new TypedProperties();
+    typeProps.putAll(typeProps);

Review comment:
       @wangxianghu 
   Use reflection just want to show the problem, method 
`StreamerUtil.getHoodieClientConfig` used `withProps` and it caused property 
value lose. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to