[GitHub] [hudi] wangxianghu commented on a change in pull request #2994: [HUDI-1931] BucketAssignFunction use wrong state

[GitBox]

wangxianghu commented on a change in pull request #2994:
URL: https://github.com/apache/hudi/pull/2994#discussion_r642415071



##########
File path: 
hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketAssignFunction.java
##########
@@ -125,12 +126,18 @@
    */
   private final boolean globalIndex;
 
+  private final double ttlTime;
+
+  private final SimpleDateFormat instantDateFormat;

Review comment:
       how about use 
`org.apache.hudi.common.table.timeline.HoodieActiveTimeline#COMMIT_FORMATTER` 
to replace `instantDateFormat ` to avoid import `SimpleDateFormat ` again ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org