garyli1019 commented on a change in pull request #3021:
URL: https://github.com/apache/hudi/pull/3021#discussion_r643226114
##########
File path: packaging/hudi-flink-bundle/pom.xml
##########
@@ -538,8 +587,16 @@
<profiles>
<profile>
- <id>flink-bundle-shade-hive</id>
+ <id>flink-bundle-shade-hive2</id>
Review comment:
should we build the bundle against different hive versions? Is that
possible to put all hive sync related stuff in the `hive-sync` package so we
don't have to maintain different set up across different compute engine?
##########
File path: packaging/hudi-flink-bundle/pom.xml
##########
@@ -505,6 +515,45 @@
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-server</artifactId>
+ <version>${jetty.version}</version>
+ <scope>${flink.bundle.hive.scope}</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-util</artifactId>
+ <version>${jetty.version}</version>
+ <scope>${flink.bundle.hive.scope}</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-webapp</artifactId>
+ <version>${jetty.version}</version>
+ <scope>${flink.bundle.hive.scope}</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-http</artifactId>
+ <version>${jetty.version}</version>
+ <scope>${flink.bundle.hive.scope}</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
Review comment:
is this being used by hive 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
