vinothchandar commented on a change in pull request #2833:
URL: https://github.com/apache/hudi/pull/2833#discussion_r645869201
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java
##########
@@ -61,8 +61,8 @@ public void lock() {
LockProvider lockProvider = getLockProvider();
int retryCount = 0;
boolean acquired = false;
- int retries =
lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP);
- long waitTimeInMs =
lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS_PROP);
+ int retries =
lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP_KEY);
Review comment:
`LockConfiguration` could also be a HoodieConfig right?
##########
File path:
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestUpgradeDowngradeCommand.java
##########
@@ -109,9 +109,10 @@ private void assertTableVersionFromPropertyFile() throws
IOException {
Path propertyFile = new Path(metaClient.getMetaPath() + "/" +
HoodieTableConfig.HOODIE_PROPERTIES_FILE);
// Load the properties and verify
FSDataInputStream fsDataInputStream =
metaClient.getFs().open(propertyFile);
- Properties prop = new Properties();
- prop.load(fsDataInputStream);
+ HoodieConfig hoodieConfig = new HoodieConfig();
+ hoodieConfig.load(fsDataInputStream);
Review comment:
Ideally. we can just have a factory method
`HoodieConfig.create(fsDataInputStream)` ? without needing the default
constructor?
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/ConfigOption.java
##########
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.config;
+
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.exception.HoodieException;
+
+import java.io.Serializable;
+import java.util.function.Function;
+import java.util.Map;
+import java.util.Objects;
+
+/**
+ * ConfigOption describes a configuration parameter. It contains the
configuration
+ * key, deprecated older versions of the key, and an optional default value
for the configuration,
+ * configuration descriptions and also the an infer mechanism to infer the
configuration value
+ * based on other configurations.
+ *
+ * @param <T> The type of the default value.
+ */
+public class ConfigOption<T> implements Serializable {
+
+ private final String key;
+
+ private final T defaultValue;
+
+ private final String description;
+
+ private final Option<String> version;
+
+ private final String[] alternatives;
Review comment:
I guess, its sufficient, if we don't end up changing anything the type
of the config option. Lets go with this for now.
##########
File path:
hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRepairsCommand.java
##########
@@ -156,10 +156,10 @@ public void testOverwriteHoodieProperties() throws
IOException {
CommandResult cr = getShell().executeCommand("repair
overwrite-hoodie-props --new-props-file " + newProps.getPath());
assertTrue(cr.isSuccess());
- Map<String, String> oldProps =
HoodieCLI.getTableMetaClient().getTableConfig().getProps();
+ Map<String, String> oldProps =
HoodieCLI.getTableMetaClient().getTableConfig().getMapProps();
Review comment:
rename: propsMap() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
