garyli1019 commented on a change in pull request #3026:
URL: https://github.com/apache/hudi/pull/3026#discussion_r645929404
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketAssignFunction.java
##########
@@ -138,7 +139,7 @@ public void open(Configuration parameters) throws Exception
{
super.open(parameters);
HoodieWriteConfig writeConfig =
StreamerUtil.getHoodieClientConfig(this.conf);
this.hadoopConf = StreamerUtil.getHadoopConf();
- this.context = new HoodieFlinkEngineContext(
+ HoodieFlinkEngineContext context = new HoodieFlinkEngineContext(
Review comment:
`engineContext` sounds good?
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketAssignFunction.java
##########
@@ -81,7 +82,7 @@
private static final Logger LOG =
LoggerFactory.getLogger(BucketAssignFunction.class);
- private HoodieFlinkEngineContext context;
+ private BucketAssignOperator.Context context;
Review comment:
rename as `operatorContext`? There are like three `context` in this
class.
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketAssignFunction.java
##########
@@ -261,13 +260,18 @@ public void close() throws Exception {
this.bucketAssigner.close();
}
+ public void setContext(BucketAssignOperator.Context context) {
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
