xushiyan commented on a change in pull request #3043:
URL: https://github.com/apache/hudi/pull/3043#discussion_r646672748
##########
File path:
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/testutils/HiveTestUtil.java
##########
@@ -146,28 +141,13 @@ public static HiveConf getHiveConf() {
return hiveServer.getHiveConf();
}
- public static HiveServer2 getHiveServer() {
- return hiveServer;
- }
-
- public static ZooKeeperServer getZkServer() {
- return zkServer;
- }
-
- public static ZookeeperTestService getZkService() {
- return zkService;
- }
-
Review comment:
not used
##########
File path:
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
##########
@@ -245,7 +246,6 @@ public void testBasicSync(boolean useJdbc, boolean
useSchemaFromCommitMetadata)
hiveClient = new HoodieHiveClient(HiveTestUtil.hiveSyncConfig,
HiveTestUtil.getHiveConf(), HiveTestUtil.fileSystem);
List<Partition> hivePartitions =
hiveClient.scanTablePartitions(HiveTestUtil.hiveSyncConfig.tableName);
List<String> writtenPartitionsSince =
hiveClient.getPartitionsWrittenToSince(Option.empty());
- writtenPartitionsSince.add(newPartition.get(0));
Review comment:
this is actually a bug; `writtenPartitionsSince` already contains the
new partition. adding this will cause 2 update events instead of 1. Not sure
why it's passing all the time.
##########
File path:
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/testutils/HiveTestUtil.java
##########
@@ -94,11 +93,7 @@
private static Set<String> createdTablesSet = new HashSet<>();
public static void setUp() throws IOException, InterruptedException {
- if (dfsCluster == null) {
- HdfsTestService service = new HdfsTestService();
- dfsCluster = service.start(true);
- configuration = service.getHadoopConf();
- }
Review comment:
clean up hdfs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
