vinothchandar commented on a change in pull request #2645:
URL: https://github.com/apache/hudi/pull/2645#discussion_r646974500
##########
File path: pom.xml
##########
@@ -533,6 +535,12 @@
<version>${spark.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
Review comment:
where is this dependency used?
##########
File path: hudi-spark-datasource/hudi-spark2/pom.xml
##########
@@ -172,10 +190,17 @@
</dependency>
<dependency>
<groupId>org.apache.hudi</groupId>
- <artifactId>hudi-spark-common</artifactId>
+ <artifactId>hudi-spark-common_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-core_${scala.binary.version}</artifactId>
+ <version>${spark2.version}</version>
+ <optional>true</optional>
Review comment:
Again curious why we needed this dependency and why it had to be
optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
