swuferhong commented on a change in pull request #3046:
URL: https://github.com/apache/hudi/pull/3046#discussion_r647090516
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/FlinkScheduleCompactionActionExecutor.java
##########
@@ -149,4 +155,41 @@ public Long parsedToSeconds(String time) {
}
return timestamp;
}
+
+ @Override
+ public Option<HoodieCompactionPlan> execute() {
+ if
(!config.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()
+ && !config.getFailedWritesCleanPolicy().isLazy()) {
+ // if there are inflight writes, their instantTime must not be less than
that of compaction instant time
+
table.getActiveTimeline().getCommitsTimeline().filterPendingExcludingCompaction().firstInstant()
Review comment:
There is a bug in BaseScheduleCompactionActionExecutor$execute as the PR
https://github.com/apache/hudi/pull/3025 want to fix, this bug will let
independence hudi compaction can not run. But this PR need to discuss, so we
choose to modify the subclass FlinkScheduleCompactionActionExecutor to finish
compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
