prashantwason commented on a change in pull request #3079:
URL: https://github.com/apache/hudi/pull/3079#discussion_r655592821



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
##########
@@ -101,11 +101,7 @@ protected BaseTableMetadata(HoodieEngineContext 
engineContext, HoodieMetadataCon
       try {
         return fetchAllPartitionPaths();
       } catch (Exception e) {
-        if (metadataConfig.enableFallback()) {
-          LOG.error("Failed to retrieve list of partition from metadata", e);
-        } else {
-          throw new HoodieMetadataException("Failed to retrieve list of 
partition from metadata", e);
-        }
+        throw new HoodieMetadataException("Failed to retrieve list of 
partition from metadata", e);

Review comment:
       Yes, disabling metadata table is the right approach for a quick fix. 
There is no user-fixable part of the table.
   
   In the long term, we expect the table to be very stable for the use-cases it 
handles. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to