veenaypatil commented on a change in pull request #3092:
URL: https://github.com/apache/hudi/pull/3092#discussion_r656759751
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -473,7 +476,9 @@ public void refreshTimeline() throws IOException {
boolean success = writeClient.commit(instantTime, writeStatusRDD,
Option.of(checkpointCommitMetadata));
if (success) {
LOG.info("Commit " + instantTime + " successful!");
-
+ if (this.props.getBoolean(ENABLE_KAFKA_COMMIT_OFFSET,
DEFAULT_ENABLE_KAFKA_COMMIT_OFFSET)) {
Review comment:
Agree, @n3nash and me discussed on various approaches here
https://issues.apache.org/jira/browse/HUDI-1910 and picked this one , hence did
not add the config to DeltaSync.
Should we implement callback approach instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
