yanghua commented on a change in pull request #3138:
URL: https://github.com/apache/hudi/pull/3138#discussion_r657032825
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/profile/WriteProfiles.java
##########
@@ -150,8 +150,8 @@ public static void clean(String path) {
Path basePath,
HoodieInstant instant,
HoodieTimeline timeline) {
- byte[] data = timeline.getInstantDetails(instant).get();
try {
+ byte[] data = timeline.getInstantDetails(instant).get();
return Option.of(HoodieCommitMetadata.fromBytes(data,
HoodieCommitMetadata.class));
} catch (IOException e) {
// make this fail safe.
Review comment:
IMO, here we should at least log the detailed exception information and
stack trace. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
