nsivabalan commented on a change in pull request #2438:
URL: https://github.com/apache/hudi/pull/2438#discussion_r657546921
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -461,7 +465,7 @@ public void refreshTimeline() throws IOException {
if (!hasErrors || cfg.commitOnErrors) {
HashMap<String, String> checkpointCommitMetadata = new HashMap<>();
checkpointCommitMetadata.put(CHECKPOINT_KEY, checkpointStr);
- if (cfg.checkpoint != null) {
+ if (cfg.checkpoint != null &&
!"timestamp".equals(props.getString("hoodie.deltastreamer.source.kafka.checkpoint.type")))
{
Review comment:
Can you help me understand why we need this ? My understanding is that,
user will set cfg.checkpoint during first batch and set the checkpoint type (to
timestamp) as well. but even for any checkpoint types, we should add the
checkpoint_reset_key here at the end of 1st batch. Am I missing something. can
you please help me understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
