liujinhui1994 commented on a change in pull request #2438:
URL: https://github.com/apache/hudi/pull/2438#discussion_r657692451
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -461,7 +465,7 @@ public void refreshTimeline() throws IOException {
if (!hasErrors || cfg.commitOnErrors) {
HashMap<String, String> checkpointCommitMetadata = new HashMap<>();
checkpointCommitMetadata.put(CHECKPOINT_KEY, checkpointStr);
- if (cfg.checkpoint != null) {
+ if (cfg.checkpoint != null &&
!"timestamp".equals(props.getString("hoodie.deltastreamer.source.kafka.checkpoint.type")))
{
Review comment:
You understand that is correct, I wanted to set the timestamp to
CHECKPOINT_RESET_KEY at the time. Considering that it could not serve a
practical purpose, I cancelled it. After listening to your thoughts, adding it
should be more appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
