veenaypatil commented on a change in pull request #3092:
URL: https://github.com/apache/hudi/pull/3092#discussion_r659271355
##########
File path:
hudi-examples/src/main/java/org/apache/hudi/examples/common/RandomJsonSource.java
##########
@@ -45,4 +45,8 @@ public RandomJsonSource(TypedProperties props,
JavaSparkContext sparkContext, Sp
return new InputBatch<>(Option.of(sparkContext.parallelize(inserts, 1)),
commitTime);
}
+
+ @Override
+ public void onCommit(String lastCkptStr) {
Review comment:
Yes, I thought about it first but Source being an abstract class dropped
that idea, should we add a new interface like `SourceCallback` which will
contain this default method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
