veenaypatil commented on a change in pull request #3071:
URL: https://github.com/apache/hudi/pull/3071#discussion_r659874413
##########
File path: pom.xml
##########
@@ -83,10 +83,10 @@
<maven-enforcer-plugin.version>3.0.0-M1</maven-enforcer-plugin.version>
<java.version>1.8</java.version>
- <fasterxml.version>2.6.7</fasterxml.version>
-
<fasterxml.jackson.databind.version>2.6.7.3</fasterxml.jackson.databind.version>
-
<fasterxml.jackson.module.scala.version>2.6.7.1</fasterxml.jackson.module.scala.version>
-
<fasterxml.jackson.dataformat.yaml.version>2.7.4</fasterxml.jackson.dataformat.yaml.version>
+ <fasterxml.version>2.10.0</fasterxml.version>
+
<fasterxml.jackson.databind.version>2.10.0</fasterxml.jackson.databind.version>
+
<fasterxml.jackson.module.scala.version>2.10.0</fasterxml.jackson.module.scala.version>
+
<fasterxml.jackson.dataformat.yaml.version>2.10.0</fasterxml.jackson.dataformat.yaml.version>
Review comment:
we can use only one property here, like use only `fasterxml.version`,
thoughts?
##########
File path: hudi-client/hudi-spark-client/pom.xml
##########
@@ -173,6 +183,18 @@
<artifactId>awaitility</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.codehaus.janino</groupId>
+ <artifactId>commons-compiler</artifactId>
+ <version>3.0.10</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.codehaus.janino</groupId>
+ <artifactId>janino</artifactId>
+ <version>3.0.10</version>
Review comment:
Had to explicitly add these as we were getting NoClassFound for some
classes. Will add the version in properties section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
