jhsb25 commented on pull request #3097: URL: https://github.com/apache/hudi/pull/3097#issuecomment-870527159
> Thanks for your contribution. Seems a valuable addition. > Few clarification: > I see that you have mentioned you have to make changes to your forked hudi to get this done. Is it just about overriding or adding your own SchemaProvider or you mean to refer to the confluent artifact versions being used? I mean, if we upgrade our confluent artifact versions w/o any changes to schema registry, would you be able to provide your own schema provider registry and get your flow working? Just trying to understand the changes required in general. > > Also, can you confirm if you have tested this patch in your staging env for both w/ and w/o credentials and it all succeeded. > > @codope : I remember you had a local confluent set up right. Do you think you can test this patch out. Also, feel free to review the patch. Hey @nsivabalan, thanks for reviewing. I can confirm that to get this working we need both the changes to confluent artifacts (upgrading the version) and also the logic changes in the `SchemaRegsitryProvider`. Whilst the logic changes to the `SchemaRegistryProvider` could possibly be added by the user providing their own schema provider it means they have to build and include their own artifact (which would hold their custom schema provider) when they want to use the hudi bundle package. This is huge additional effort for anyone wanting to use the hudi bundle with basic auth for schema registry so i think its quite valuable to include this logic it in the `SchemaRegsitryProvider` class. I can confirm i have tested this in my staging env with and without credentials and it has all succeeded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
