leesf commented on a change in pull request #3183:
URL: https://github.com/apache/hudi/pull/3183#discussion_r660655900



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/util/collection/DiskBasedMap.java
##########
@@ -111,8 +111,14 @@ private void initFile(File writeOnlyFile) throws 
IOException {
     if (writeOnlyFile.exists()) {
       writeOnlyFile.delete();
     }
-    if (!writeOnlyFile.getParentFile().exists()) {
-      writeOnlyFile.getParentFile().mkdir();
+    File parentDir = writeOnlyFile.getParentFile();
+    if (!parentDir.exists()) {
+      parentDir.mkdir();
+      // we should set all right for other user.

Review comment:
       `we should set all rights for all users, otherwise some users cannot 
access this directory and cause query to fail?` and is it possible to add unit 
test for this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to