rmahindra123 edited a comment on pull request #3117: URL: https://github.com/apache/hudi/pull/3117#issuecomment-870852282
> I see we have more test coverage in TestExternalSpillableMap. Can we parametrize the tests that are applicable and run those for both type of spillable maps. I had tests for TestExternalSpillableMap in the stacked diff, anyway added it here. > In general, do we have tests around diff values for maxInMemorySizeInBytes for external spillable map. If not, do you think we can add them while we are at this. We do test if the right amount of keys were in memory and the right amount was spilled over. Wondering how different values of maxInMemorySizeInBytes will help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
