sbernauer commented on a change in pull request #3172:
URL: https://github.com/apache/hudi/pull/3172#discussion_r660951463
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/AvroKafkaSource.java
##########
@@ -60,7 +66,7 @@ public AvroKafkaSource(TypedProperties props,
JavaSparkContext sparkContext, Spa
super(props, sparkContext, sparkSession, schemaProvider);
props.put(NATIVE_KAFKA_KEY_DESERIALIZER_PROP, StringDeserializer.class);
- String deserializerClassName =
props.getString(DataSourceWriteOptions.KAFKA_AVRO_VALUE_DESERIALIZER(), "");
+ String deserializerClassName =
props.getString(KAFKA_AVRO_VALUE_DESERIALIZER_OPT_KEY(),
DEFAULT_KAFKA_AVRO_VALUE_DESERIALIZER_OPT_VAL());
Review comment:
Hi, i would prefer to leave the block in - even if we turn the feature
on by default. Doing so we have the possibility to turn the feature explicitly
off (`hoodie.deltastreamer.source.kafka.value.deserializer.class=`) if it
causes any problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
