wangxianghu commented on a change in pull request #3177:
URL: https://github.com/apache/hudi/pull/3177#discussion_r661166648
##########
File path:
hudi-flink/src/main/java/org/apache/hudi/streamer/FlinkStreamerConfig.java
##########
@@ -287,7 +283,6 @@
org.apache.flink.configuration.Configuration conf = fromMap(propsMap);
conf.setString(FlinkOptions.PATH, config.targetBasePath);
- conf.setString(FlinkOptions.READ_AVRO_SCHEMA_PATH,
config.readSchemaFilePath);
Review comment:
> Can we also refactor the `READ_AVRO_SCHEMA_PATH ` config option. I
would like to remove `READ_`. WDYT?
Maybe `SOURCE_` is more appropriate.
we add the prefix string is because hudi supports schema evolution. in
`hudi-utilities` module we call it sourceSchema and targetSchema, these two
schemas may be different.
here Danny calls it `READ_`, that's because it is used in streaming read
too, also reasonable.
I actually prefer `SOURCE_` and `TARGET_` prefix, taking schema evolution
support into consideration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
