[
https://issues.apache.org/jira/browse/HUDI-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372336#comment-17372336
] ASF GitHub Bot commented on HUDI-2088: -------------------------------------- codecov-commenter edited a comment on pull request #3171: URL: https://github.com/apache/hudi/pull/3171#issuecomment-869617946 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3171?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3171](https://codecov.io/gh/apache/hudi/pull/3171?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27532c7) into [master](https://codecov.io/gh/apache/hudi/commit/7895a3586e19a7f66fc2a400c90d8334f255d943?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7895a35) will **decrease** coverage by `9.19%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/hudi/pull/3171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #3171 +/- ## ============================================ - Coverage 58.91% 49.71% -9.20% + Complexity 1194 405 -789 ============================================ Files 163 67 -96 Lines 6435 2985 -3450 Branches 672 320 -352 ============================================ - Hits 3791 1484 -2307 + Misses 2372 1365 -1007 + Partials 272 136 -136 ``` | Flag | Coverage Δ | | |---|---|---| | hudiclient | `?` | | | hudiutilities | `49.71% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/3171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...apache/hudi/utilities/deltastreamer/DeltaSync.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvRGVsdGFTeW5jLmphdmE=) | `71.04% <100.00%> (-0.25%)` | :arrow_down: | | [...he/hudi/table/action/commit/SparkDeleteHelper.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9TcGFya0RlbGV0ZUhlbHBlci5qYXZh) | | | | [...java/org/apache/hudi/client/HoodieWriteResult.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZVdyaXRlUmVzdWx0LmphdmE=) | | | | [.../bootstrap/HoodieSparkBootstrapSchemaProvider.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2Jvb3RzdHJhcC9Ib29kaWVTcGFya0Jvb3RzdHJhcFNjaGVtYVByb3ZpZGVyLmphdmE=) | | | | [...apache/hudi/keygen/TimestampBasedKeyGenerator.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkva2V5Z2VuL1RpbWVzdGFtcEJhc2VkS2V5R2VuZXJhdG9yLmphdmE=) | | | | [...mmit/SparkDeletePartitionCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9TcGFya0RlbGV0ZVBhcnRpdGlvbkNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | | | | [...it/SparkBulkInsertPreppedCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9TcGFya0J1bGtJbnNlcnRQcmVwcGVkQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | | | | [...arkBulkInsertPreppedDeltaCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2RlbHRhY29tbWl0L1NwYXJrQnVsa0luc2VydFByZXBwZWREZWx0YUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | | | | [...t/SparkInsertPreppedDeltaCommitActionExecutor.java](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2RlbHRhY29tbWl0L1NwYXJrSW5zZXJ0UHJlcHBlZERlbHRhQ29tbWl0QWN0aW9uRXhlY3V0b3IuamF2YQ==) | | | | ... and [88 more](https://codecov.io/gh/apache/hudi/pull/3171/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3171?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3171?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7895a35...27532c7](https://codecov.io/gh/apache/hudi/pull/3171?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > Missing Partition Fields And PreCombineField In Hoodie Properties For Table > Written By Flink > -------------------------------------------------------------------------------------------- > > Key: HUDI-2088 > URL: https://issues.apache.org/jira/browse/HUDI-2088 > Project: Apache Hudi > Issue Type: Bug > Components: Flink Integration, Spark Integration > Reporter: pengzhiwei > Assignee: pengzhiwei > Priority: Major > Labels: pull-request-available > Fix For: 0.9.0 > > > Currently we have missed the partition fields and preCombineField in > hoodie.properites when init the table by flink which will cause two problems: > 1、spark partition prune will not work if missing he partition fields. > 2、spark query mor table will return incorrect result if missing the > preCombineField. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
