[
https://issues.apache.org/jira/browse/HUDI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372872#comment-17372872
]
ASF GitHub Bot commented on HUDI-2115:
--------------------------------------
leesf commented on a change in pull request #3206:
URL: https://github.com/apache/hudi/pull/3206#discussion_r662380290
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java
##########
@@ -62,9 +60,7 @@
public HoodieFileGroup(HoodieFileGroup fileGroup) {
this.timeline = fileGroup.timeline;
this.fileGroupId = fileGroup.fileGroupId;
- this.fileSlices = new TreeMap<>(fileGroup.fileSlices.entrySet().stream()
- .map(e -> Pair.of(e.getKey(), new FileSlice(e.getValue())))
- .collect(Collectors.toMap(Pair::getKey, Pair::getValue)));
+ this.fileSlices = new TreeMap<>(fileGroup.fileSlices);
Review comment:
would you please write an unit test to cover the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> FileSlices in the filegroup is not descending by timestamp
> ----------------------------------------------------------
>
> Key: HUDI-2115
> URL: https://issues.apache.org/jira/browse/HUDI-2115
> Project: Apache Hudi
> Issue Type: Bug
> Reporter: XiaoyuGeng
> Assignee: XiaoyuGeng
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
