satishkotha commented on pull request #3153: URL: https://github.com/apache/hudi/pull/3153#issuecomment-872586093
> @satishkotha : Thanks for adding this very useful feature. One high level comment: For validations, sometimes we want the complete view of the table for doing global uniqueness check across partitions. I see that SparkPrecommitValidator has getPartitionsModified API which can be overridden to get it but that would mean that we can't reuse the SQL based validators without having to override them. Can we make it configurable to perform global vs local checks ? > > Will let you clean up the code and will do the final review when it is ready. > > Thanks. > Balaji.V @bvaradar This seems like a new feature request. Can we handle this as part of another PR? Btw, do you think global uniqueness can be checked before the write stage starts (using the index)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
