wangxianghu commented on pull request #3162: URL: https://github.com/apache/hudi/pull/3162#issuecomment-872641634
> > Yes, I agree with you on creating a new module , but let's not put it under the original hudi-utilities-bundle. > > I prefer this: > > hudi-utilities-bundle > > ├── hudi-flink-utilities-bundle > > └── hudi-spark-utilities-bundle > > I am not suggesting to create modules under `hudi-utilities-bundle`, Also, in the bundle we are not adding any classes. Since we are moving some Flink classes to `hudi-utilities` module , we will have to create modules under it, something like > > hudi-utilities > ├── hudi-flink-utilities > └── hudi-spark-utilities > > and then we can add these two as part of `hudi-utilities-bundle` here https://github.com/apache/hudi/blob/master/packaging/hudi-utilities-bundle/pom.xml#L70 like the we way we have added `hudi-hive-sync` module from `hudi-sync` project. The utilities-bundle jars should be engine-related. each jar for one engine(use different dependencies). if you want to put these bundles under `hudi-utilities-bundle`, could be: ``` hudi-utilities-bundle ├── hudi-flink-utilities-bundle └── hudi-spark-utilities-bundle ``` but these ways do not respect backward compatibility， user should use new jars(hudi-xxx-utilities) to start their jobs another option: add a new bundle for `HoodieFLinkStreamer` that's is `hudi-flink-utilities`, leave the others untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
